Skip to content

Drop reputation and account age from curation desk rows - #1744

Merged
feruzm merged 1 commit into
developfrom
design/curation-row-byline
Sep 6, 2026
Merged

Drop reputation and account age from curation desk rows#1744
feruzm merged 1 commit into
developfrom
design/curation-row-byline

Conversation

@feruzm

@feruzm feruzm commented Sep 6, 2026

Copy link
Copy Markdown
Member

The author in a desk row is wrapped in ProfilePopover. Its hover card already shows the reputation next to the username and the joined date, so rep 73 and 6 y in the byline repeated that on every row.

Account age was not purely informational, though: it turned amber under 30 days, which is a review signal the hover card does not reproduce. So it stays, in the smallest form that carries the signal.

  • rep is gone from the row byline. The quick view keeps it, since there is no hover card to fall back on there.
  • AuthorAgeChip becomes NewAccountChip: nothing for an established account, an amber New account chip under 30 days.
  • The three row.age-* strings collapse into one row.new-account.
  • The New · post #N chip (post count) is untouched.

Testing

  • 400 test files / 3931 tests pass, typecheck and lint clean
  • the spec now pins the chip's absence for an established account; mutating the 30-day guard away fails it
  • checked on a dev server against live queue data: the byline reads author, community, word count, with the amber chip only on genuinely new accounts

@feruzm
Drop reputation and account age from curation desk rows
4e5c2a1 
The author in a row is wrapped in ProfilePopover, whose hover card already
carries the reputation next to the username and the joined date, so "rep 73"
and "6 y" in the byline were repeating it a second time on every row.

Account age was not purely informational though: it turned amber under 30
days. That part is a review signal the hover card does not reproduce, so it
stays as a compact New account chip that appears only inside that window.
AuthorAgeChip becomes NewAccountChip and the three age strings collapse to
one. The quick view keeps its rep, where there is no hover card to fall back
on.
@qodo-code-review

qodo-code-review Bot commented Sep 6, 2026

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing

@coderabbitai

coderabbitai Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 42 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 76108ffd-1b2b-463a-85d7-f825388d5a1d

📥 Commits

Reviewing files that changed from the base of the PR and between d4bb9ec and 4e5c2a1.

📒 Files selected for processing (3)
  • apps/web/src/features/curation-desk/curation-queue-row.tsx
  • apps/web/src/features/i18n/locales/en-US.json
  • apps/web/src/specs/features/curation-desk/curation-window-badge.spec.tsx

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Sep 6, 2026

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day 
💡 Did you know, you can show, collapse, or hide each part of a finding: code, evidence, and all

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Sep 6, 2026

Copy link
Copy Markdown

PR Summary by Qodo

Simplify curation row author metadata

✨ Enhancement 🧪 Tests 🕐 10-20 Minutes

Grey Divider

AI Description 

• Removes duplicated reputation and established-account age from curation queue bylines.
• Preserves reviewer signaling with an amber chip for accounts under 30 days.
• Keeps reputation in quick view and verifies conditional chip behavior.
Diagram 

graph TD
  A["Desk row"] --> B["Queue byline"] --> C{"Under 30 days?"} -->|Yes| D["Amber chip"]
  C -->|No| E["No age label"]
  B --> F["Profile hover"]
Loading
High-Level Assessment

The current approach is appropriate: it removes metadata already available in ProfilePopover while retaining the actionable new-account signal directly in each row. Keeping all age and reputation values would preserve redundant clutter, while moving the warning exclusively into the hover card would make an important review signal less discoverable.

Files changed (3) +23 / -22

Enhancement (1) +11 / -13
curation-queue-row.tsxReplace row age and reputation text with a conditional warning chip +11/-13

Replace row age and reputation text with a conditional warning chip

• Removes reputation and formatted account age from queue-row bylines. Renames AuthorAgeChip to NewAccountChip and renders an amber New account chip only when the author account is less than 30 days old.

apps/web/src/features/curation-desk/curation-queue-row.tsx

Tests (1) +11 / -6
curation-window-badge.spec.tsxTest conditional new-account signaling and byline simplification +11/-6

Test conditional new-account signaling and byline simplification

• Updates account-age assertions for the amber New account chip and verifies it is absent for established or undated accounts. Also confirms reputation no longer appears in the queue-row byline.

apps/web/src/specs/features/curation-desk/curation-window-badge.spec.tsx

Other (1) +1 / -3
en-US.jsonConsolidate account-age translations into one warning label +1/-3

Consolidate account-age translations into one warning label

• Removes the day, month, and year age strings and adds the New account label. The existing reputation string remains available for the quick view.

apps/web/src/features/i18n/locales/en-US.json

@feruzm
feruzm merged commit 2501b52 into develop Sep 6, 2026
8 checks passed
@feruzm
feruzm deleted the design/curation-row-byline branch September 6, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@feruzm